Lab 1 Peer Review
There is two things that I would say are need to be fixed.
- On the
boot0
there should be a pull-down resistor, you could search on goolge how to make it. - You should add some test points to ground and power line
There is also some things that is not nessesery to do but could help
- Your power net with same name are connected so you do not need to make multiple leds on the same voltage node.
- You could fix so not all of your labels are input, it makes it easier to check your schematic.
- Sometimes you use
my
and other times"u"
, it would be better to go for one of them and I would recommend"u"
as it's often used. - Footprint for
JP1
should be bigger then1x01
.
Also by the instruction you should have 3 warnings instead you have only 2. You could fix this by removing the pwr_flag at the usb connection to +5V
. :)
Otherwise everything looks good mostly small fixes that was needed.